From dda37d6f9f40d573776ac4bb6abe12adb8f33c47 Mon Sep 17 00:00:00 2001
From: colin <colin@cicadas.surf>
Date: Fri, 29 Nov 2024 07:23:09 -0800
Subject: More complete debugging of request lifecycle

---
 src/protocol.lisp | 51 +++++++++++++++------------------------------------
 1 file changed, 15 insertions(+), 36 deletions(-)

(limited to 'src/protocol.lisp')

diff --git a/src/protocol.lisp b/src/protocol.lisp
index 3a4f3ec..ea6639a 100644
--- a/src/protocol.lisp
+++ b/src/protocol.lisp
@@ -2,34 +2,8 @@
 
 ;;; CONDITIONS
 
-(defvar *debugging* nil
-  "If T, the debugger will be evoked.")
-
-(defvar *debug-indent* nil
-  "If an integer, debug print will print this many spaces before printing the debug message. It will then increment the count. 
-
-The debug indent is bound when request handling starts.")
-
-(defvar *debug-lock* nil
-  "Whens set, use this to ensure that writing to the debug stream doesn't
-interleave writes across threads")
-
-(defun toggle-debugging ()
-  (setf
-   *debug-lock* (bt:make-lock)
-   *debugging* (not *debugging*)))
-
-(declaim (inline debug-print))
-(defun debug-print (&rest objects)
-  (when *debugging*
-    (bt:with-lock-held (*debug-lock*)
-      (write-string "DEBUG: " *error-output*)
-      (loop :repeat (or *debug-indent* 0)
-            :do (write-char #\space *error-output*))
-      (format *error-output* "~{~s ~}~%" objects)
-      (when *debug-indent* (incf *debug-indent* 2)))))
-
-(define-condition protocol-error (error)
+
+(define-condition protocol-error ()
   ((raw-request
     :reader raw-request
     :initform nil
@@ -64,7 +38,7 @@ indicating that the user's identity is required but cannot be determined."))
   (:documentation "Signalled when an endpoint's AUTHORIZE method returns NIL, indiating
 that the request has insufficient permissions to evoke the endpoint handler. "))
 
-(define-condition bad-body-error (protocol-error)
+(define-condition bad-body-error (error protocol-error)
   ((wrapped
     :reader wrapped
     :initarg :error
@@ -73,7 +47,7 @@ that the request has insufficient permissions to evoke the endpoint handler. "))
   (:default-initargs :status-code 400)
   (:documentation "Signalled when the body of a request cannot be deserialized, for any reason.."))
 
-(define-condition slot-required (protocol-error)
+(define-condition slot-required (error protocol-error)
   ((mising-slot
     :reader missing-slot
     :initform nil
@@ -94,7 +68,7 @@ that the request has insufficient permissions to evoke the endpoint handler. "))
   (:documentation
    "The content and mimetype to returned to the client having encountered
     an error.")
-  (:method ((err error)) (values nil nil)))
+  (:method ((err t)) (values nil nil)))
 
 (defun abort-on-error (err)
   "Assign a return code based on the type of error encountered and
@@ -112,10 +86,13 @@ that the request has insufficient permissions to evoke the endpoint handler. "))
     (error (err)
       (if *debugging*
           (invoke-debugger err)
-          (abort-on-error err)))))
+          (abort-on-error err)))
+    (protocol-error (err)
+      (abort-on-error err))))
 
 (defun protocol-error (error-class ep &rest kwargs)
-  (apply #'error
+  (debug-print :protocol-error error-class kwargs)
+  (apply #'signal
          error-class
          :raw-request (and (boundp 'http:*request*) http:*request*)
          :class ep
@@ -205,8 +182,9 @@ MUST be implemented for every endpoint class.")
   (:method :around ((endpoint t))
     (debug-print :handling endpoint)
     (prog1 (call-next-method)
-      (debug-print :content-type (http:content-type*)
-                   :content-length (http:content-length*))
+      (debug-print
+       :replying-with (http:return-code*)
+       :content-type (http:content-type*))
       (debug-print)))
 
   (:method :before ((endpoint t))
@@ -215,7 +193,8 @@ MUST be implemented for every endpoint class.")
     (unless (authenticate endpoint)
       (protocol-error 'cannot-authenticate endpoint))
     (unless (authorize endpoint)
-      (protocol-error 'not-authorized endpoint))))
+      (protocol-error 'not-authorized endpoint))
+    (debug-print :proceeding-to-handler)))
 
 ;;; HANDLER TOOLS
 
-- 
cgit v1.2.3